Complete Role D: factorial support, import fix, git recovery tasks, and history cleanup#29
Open
tngwafor wants to merge 9 commits into
Open
Complete Role D: factorial support, import fix, git recovery tasks, and history cleanup#29tngwafor wants to merge 9 commits into
tngwafor wants to merge 9 commits into
Conversation
This reverts commit 6ca467b.
|
The PR description is thorough, but it would help to add a short 1-2 sentence summary at the top explaining what this branch is and why it's being merged, rather than just listing what was done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes all Role D requirements and describes my contributions.
Code changes
tests/test_calculator.py.gitignoreto ignore Python cache filesis_positivehelper function tosrc/validator.pyGit workflow tasks completed
starter/role-DBAD:commit withgit revertmainto the feature branch withgit cherry-pickgit reflogmainValidation
pytest tests/passes locallyNotes
LEARNINGS-tngwafor.mdis included in this branchChecklist